| Summary: | Better pack ResourceRequest | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ggaren, koivisto, lforschler, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2018-06-15 19:16:14 PDT
Created attachment 342867 [details]
Patch
Comment on attachment 342867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342867&action=review > Source/WebCore/platform/network/ResourceRequestBase.h:245 > + String m_initiatorIdentifier; > + String m_cachePartition { emptyString() }; Wouldn't it be better to move the Strings before the bools? Created attachment 342885 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 342867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342867&action=review > > > Source/WebCore/platform/network/ResourceRequestBase.h:245 > > + String m_initiatorIdentifier; > > + String m_cachePartition { emptyString() }; > > Wouldn't it be better to move the Strings before the bools? It does not help but I moved them for cleanliness. Comment on attachment 342885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342885&action=review > Source/WebCore/ChangeLog:9 > + Better pack ResourceRequest to reduce its size from 240 to 232 bytes > + on Mac. What helps us monitor this in the future? I can easily imagine I might ruin the packing if it was invisible to me that I was doing that. Some kind of size static assertion? Comment on attachment 342885 [details] Patch Clearing flags on attachment: 342885 Committed r232949: <https://trac.webkit.org/changeset/232949> All reviewed patches have been landed. Closing bug. |