Bug 186706

Summary:

ContentSecurityPolicySourceList wastes 51KB of Vector capacity on cnn.com

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Page Loading

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, commit-queue, dbates, ews-watchlist, mkwst, simon.fraser, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Simon Fraser (smfr) 2018-06-15 15:08:36 PDT

Tooling from bug 186698:

Wasted capacity: 51264 bytes (used 13248 of 64512 bytes, utilization: 20.54%) - 132 allocations
1   0x10810c735 WTF::VectorBuffer<WebCore::ContentSecurityPolicySource, 0ul>::VectorBuffer()
2   0x10810c715 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
3   0x108109d05 WTF::Vector<WebCore::ContentSecurityPolicySource, 0ul, WTF::CrashOnOverflow, 16ul>::Vector()
4   0x108109c72 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&)
5   0x108109d55 WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList(WebCore::ContentSecurityPolicy const&, WTF::String const&)
6   0x10810bec7 WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&)
7   0x10810bf1d WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective(WebCore::ContentSecurityPolicyDirectiveList const&, WTF::String const&, WTF::String const&)
8   0x1080f0e3f void WebCore::ContentSecurityPolicyDirectiveList::setCSPDirective<WebCore::ContentSecurityPolicySourceListDirective>(WTF::String const&, WTF::String const&, std::__1::unique_ptr<WebCore::ContentSecurityPolicySourceListDirective, std::__1::default_delete<WebCore::ContentSecurityPolicySourceListDirective> >&)

Comment 1 Radar WebKit Bug Importer 2018-06-15 15:09:06 PDT

<rdar://problem/41173711>

Comment 2 Chris Dumez 2018-06-15 15:14:43 PDT

Adding Daniel to cc since this is CSP.

Comment 3 Simon Fraser (smfr) 2018-06-20 11:29:24 PDT

Created attachment 343168 [details]
Patch

Comment 4 WebKit Commit Bot 2018-06-20 12:39:07 PDT

Comment on attachment 343168 [details]
Patch

Clearing flags on attachment: 343168

Committed r233019: <https://trac.webkit.org/changeset/233019>

Comment 5 WebKit Commit Bot 2018-06-20 12:39:09 PDT

All reviewed patches have been landed.  Closing bug.