Bug 186686

Summary: [ESNext] Symbol.prototype.description
Product: WebKit Reporter: Leo Balter <leo>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, ljharb, mark.lam, msaboff, ross.kirsling, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Leo Balter
Reported 2018-06-15 12:35:41 PDT
Currently on Stage 3. https://github.com/tc39/proposal-Symbol-description On Test262 test/built-ins/Symbol/prototype/description using feature tag "Symbol.prototype.description"
Attachments
Patch (4.72 KB, patch)
2018-09-05 13:56 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.75 KB, patch)
2018-09-05 14:39 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-09-05 13:56:11 PDT
Created attachment 348962 [details] Patch
Keith Miller
Comment 2 2018-09-05 14:14:42 PDT
Comment on attachment 348962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348962&action=review > JSTests/stress/symbol-description.js:-22 > -var s1 = Symbol("Cappuccino"); Please put this one back. There's no reason to remove it as it's not like it makes anything measurably slower.
Keith Miller
Comment 3 2018-09-05 14:15:21 PDT
Other than the test lgtm.
Ross Kirsling
Comment 4 2018-09-05 14:39:50 PDT
Created attachment 348965 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-09-05 15:18:16 PDT
Comment on attachment 348965 [details] Patch for landing Clearing flags on attachment: 348965 Committed r235712: <https://trac.webkit.org/changeset/235712>
WebKit Commit Bot
Comment 6 2018-09-05 15:18:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-05 15:19:42 PDT
<rdar://problem/44156631>
Jordan Harband
Comment 8 2018-09-05 15:42:48 PDT
Presumably this will land in nightly tonight; when might it land in TP?
Ross Kirsling
Comment 9 2018-09-05 15:48:25 PDT
(In reply to Jordan Harband from comment #8) > Presumably this will land in nightly tonight; when might it land in TP? I believe it's every other Wednesday, so most likely 9/12?
Note You need to log in before you can comment on or make changes to this bug.