Bug 186677

Summary: REGRESSION (r232799): Form controls are blank in dark mode
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: FormsAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Bug
none
Patch
none
With Patch none

Description Timothy Hatcher 2018-06-15 10:09:02 PDT 
After fixing bug 186597, the controls in dark mode stopped rendering.
Comment 1 Radar WebKit Bug Importer 2018-06-15 10:09:16 PDT 
<rdar://problem/41162899>
Comment 2 Timothy Hatcher 2018-06-15 10:09:17 PDT 
Created attachment 342822 [details]
Bug
Comment 3 Timothy Hatcher 2018-06-15 10:12:37 PDT 
Created attachment 342823 [details]
Patch
Comment 4 Wenson Hsieh 2018-06-15 10:13:36 PDT 
Comment on attachment 342823 [details]
Patch

Thanks for catching this!
Comment 5 Timothy Hatcher 2018-06-15 10:15:35 PDT 
Created attachment 342824 [details]
With Patch
Comment 6 WebKit Commit Bot 2018-06-15 10:33:00 PDT 
Comment on attachment 342823 [details]
Patch

Clearing flags on attachment: 342823

Committed r232880: <https://trac.webkit.org/changeset/232880>
Comment 7 WebKit Commit Bot 2018-06-15 10:33:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2018-06-15 22:13:53 PDT 
Comment on attachment 342823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342823&action=review

> Source/WebCore/ChangeLog:13
> +        Dark mode controls don't have borders, just a semi-transparent background of shadows.
> +        In the dark mode case we can't disable borders, or we will not paint anything for the control.

How do we regression test such things?