Bug 186674

Summary: Need to properly handle removal of worker in SWServer::unregisterServiceWorkerClient timer lambda
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bugs-noreply, calvaris, cdumez, commit-queue, ews-watchlist, ltilve+ews, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2 none

Description youenn fablet 2018-06-15 09:43:49 PDT
Need to properly handle removal of worker in SWServer::unregisterServiceWorkerClient timer lambda
Comment 1 youenn fablet 2018-06-15 09:44:04 PDT
<rdar://problem/40974812>
Comment 2 youenn fablet 2018-06-15 09:52:44 PDT
Created attachment 342818 [details]
WIP
Comment 3 Igalia-pontevedra EWS 2018-06-18 20:38:06 PDT
Comment on attachment 342818 [details]
WIP

Attachment 342818 [details] did not pass gtk-wk2-ews (gtk-wk2):
Output: http://webkit-queues.webkit.org/results/8240849

New failing tests:
media/video-currentTime-set.html
Comment 4 Igalia-pontevedra EWS 2018-06-18 20:38:10 PDT
Created attachment 343015 [details]
Archive of layout-test-results from ltilve-gtk-wk2-ews for gtk-wk2

The attached test failures were seen while running run-webkit-tests on the gtk-wk2-ews.
Bot: ltilve-gtk-wk2-ews  Port: gtk-wk2  Platform: Linux-4.16.0-0.bpo.1-amd64-x86_64-with-debian-9.4
Comment 5 youenn fablet 2018-06-19 09:22:55 PDT
Created attachment 343060 [details]
Patch
Comment 6 Chris Dumez 2018-06-19 10:34:05 PDT
Comment on attachment 343060 [details]
Patch

r=me
Comment 7 EWS Watchlist 2018-06-19 10:34:51 PDT
Comment on attachment 343060 [details]
Patch

Attachment 343060 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8248761

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 8 EWS Watchlist 2018-06-19 10:34:52 PDT
Created attachment 343064 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 youenn fablet 2018-06-19 13:26:55 PDT
Comment on attachment 343060 [details]
Patch

mac-wk2 issue is unrelated
Comment 10 WebKit Commit Bot 2018-06-19 13:53:40 PDT
Comment on attachment 343060 [details]
Patch

Clearing flags on attachment: 343060

Committed r232981: <https://trac.webkit.org/changeset/232981>
Comment 11 WebKit Commit Bot 2018-06-19 13:53:42 PDT
All reviewed patches have been landed.  Closing bug.