| Summary: | [GTK][WPE] WebDriver: handle acceptInsecureCertificates capability | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||||
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, berto, bugs-noreply, calvaris, ews-watchlist, gustavo, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer, zan | ||||||||||
| Priority: | P2 | Keywords: | Gtk, InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186557 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Carlos Garcia Campos
2018-06-12 05:39:05 PDT
Created attachment 342526 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 342527 [details]
Patch
Comment on attachment 342527 [details] Patch Attachment 342527 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8147166 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html http/tests/preload/onload_event.html Created attachment 342537 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 342527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342527&action=review Everything else looks fine except the issue noted. > Source/WebDriver/ChangeLog:9 > + cabaility is sent. Nit: capability > Source/WebKit/UIProcess/Cocoa/AutomationClient.mm:89 > + dispatch_async(dispatch_get_main_queue(), ^{ r- because this causes a UAF (which I only caught by applying manually and running tests ;-)). You need to do the following outside the block: NSString *requestedSessionIdentifier = sessionIdentifier; then use that NSString as the argument rather than applying the type conversion inside the block. The WTFString may no longer be around at that time. Created attachment 342639 [details]
Updated patch
Comment on attachment 342639 [details]
Updated patch
r=me
Committed r232833: <https://trac.webkit.org/changeset/232833> |