| Summary: | [GTK] Enable tests on the GTK EWS queue | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||||||
| Status: | REOPENED --- | ||||||||||
| Severity: | Normal | CC: | agomez, bugs-noreply, calvaris, cgarcia, commit-queue, ews-watchlist, glenn, lforschler, mcatanzaro, psaavedra, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186638 | ||||||||||
| Bug Depends on: | 186843 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Carlos Alberto Lopez Perez
2018-06-12 04:42:48 PDT
Created attachment 342525 [details]
Patch
Comment on attachment 342525 [details] Patch Attachment 342525 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8146053 New failing tests: js/dom/JSON-stringify.html Created attachment 342531 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 342525 [details]
Patch
OK, let's see how it goes.
(In reply to Build Bot from comment #2) > Comment on attachment 342525 [details] > Patch > > Attachment 342525 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/8146053 > > New failing tests: > js/dom/JSON-stringify.html We'll need to do better than Mac at avoiding spam comments caused by flaky tests. :/ Anyway, we can always switch back if it's too much of a problem, so let's give it a try. (In reply to Michael Catanzaro from comment #4) > Comment on attachment 342525 [details] > Patch > > OK, let's see how it goes. Thanks for the review.. before landing I think we should do an extra effort to make the release GTK bot green Comment on attachment 342525 [details] Patch Attachment 342525 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8162650 New failing tests: http/tests/security/local-video-source-from-remote.html http/tests/preload/onload_event.html Created attachment 342650 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ok.. the GTK bot is now almost green (1 failure as of r232840) Let's land this now and see how it goes. Comment on attachment 342525 [details] Patch Clearing flags on attachment: 342525 Committed r232844: <https://trac.webkit.org/changeset/232844> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 186843 |