| Summary: | http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html times out with PSON enabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 186542 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2018-06-11 15:47:18 PDT
I believe the issue is that we process swap when navigated a frame that has opened a window. This is not OK at the moment because the new window can have a WindowProxy to its opener (which those tests rely on). We currently prevent PSON if we have an opener, we should also prevent PSON if FrameLoader::m_openedFrames is not empty. Created attachment 342476 [details]
Patch
Comment on attachment 342476 [details]
Patch
Hate having a second copy of the test just for the PSON version... =(
Comment on attachment 342476 [details] Patch Attachment 342476 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8138653 New failing tests: fast/css/counters/element-removal-crash.xhtml Created attachment 342493 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Brady Eidson from comment #3) > Comment on attachment 342476 [details] > Patch > > Hate having a second copy of the test just for the PSON version... =( We can drop them once PSON is enabled by default. Comment on attachment 342476 [details] Patch Clearing flags on attachment: 342476 Committed r232737: <https://trac.webkit.org/changeset/232737> All reviewed patches have been landed. Closing bug. |