| Summary: | Add ByteString as a string that adheres to WebIDL ByteString constraints | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, benjamin, bfulgham, cdumez, cmarcelo, dbates, ews-watchlist, rniwa, sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2018-06-11 13:33:37 PDT
Created attachment 342462 [details]
Patch
Comment on attachment 342462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342462&action=review > Source/WebCore/ChangeLog:8 > + Modify IDL conversion to instantiate WTF::ByteString instead of WTF::String. Is it really worth adding yet one more string type? This is not required for correct behavior since the JS bindings already dealt with ByteString correctly. I am personally not convinced this is an improvement and find it surprising with add Web IDL concepts in WTF. Created attachment 342486 [details]
Fixing compilation
Comment on attachment 342486 [details] Fixing compilation Attachment 342486 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8140083 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/overridemimetype-blob.html Created attachment 342502 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Is this needed anymore? Unfortunately, it didn't had any test case in the attached patch so I couldn't check. :-( Just trying to close old bugs etc., so don't mind my bumps. Thanks! |