| Summary: | Add a command line default to force WebKitTestRunner to turn on process swap on navigation | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
| Component: | Tools / Tests | Assignee: | Brady Eidson <beidson> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, ggaren, lforschler, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186537 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Brady Eidson
2018-06-11 11:52:05 PDT
Created attachment 342453 [details]
Patch
Comment on attachment 342453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342453&action=review > Tools/WebKitTestRunner/TestController.cpp:1126 > + testOptions.enableProcessSwapOnWindowOpen = testOptions.enableProcessSwapOnNavigation; I do not think we want the default to enabled this feature as it is far from ready. The short term plan is to only enable PSON without window open support. (In reply to Chris Dumez from comment #2) > Comment on attachment 342453 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342453&action=review > > > Tools/WebKitTestRunner/TestController.cpp:1126 > > + testOptions.enableProcessSwapOnWindowOpen = testOptions.enableProcessSwapOnNavigation; > > I do not think we want the default to enabled this feature as it is far from > ready. The short term plan is to only enable PSON without window open > support. This patch did not change any behavior. Previously if a test enabled PSON, it also got PSOWO That same thing holds true with this patch. The new default *only* enables PSON. Comment on attachment 342453 [details] Patch Attachment 342453 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8133469 New failing tests: media/video-buffering-allowed.html Created attachment 342458 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 342453 [details] Patch r=me but needs rebaseline due to <https://trac.webkit.org/changeset/232729>. This patch did *not* change the results of the failing video test. Created attachment 342463 [details]
Patch
Comment on attachment 342463 [details] Patch Clearing flags on attachment: 342463 Committed r232732: <https://trac.webkit.org/changeset/232732> All reviewed patches have been landed. Closing bug. |