Bug 186521

Summary:

[webkitpy] PHP7.2 support on Debian platforms

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, lforschler, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Philippe Normand 2018-06-11 06:53:18 PDT

Comment 1 Philippe Normand 2018-06-11 06:56:42 PDT

Created attachment 342426 [details]
Patch

Comment 2 Michael Catanzaro 2018-06-11 07:11:18 PDT

Comment on attachment 342426 [details]
Patch

How does the new .conf file get used...?

Comment 3 Philippe Normand 2018-06-11 07:23:41 PDT

_apache_config_file_name_for_platform() in base.py returns the conf filename.

Comment 4 Michael Catanzaro 2018-06-11 07:24:55 PDT

Comment on attachment 342426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342426&action=review

> Tools/Scripts/webkitpy/port/base.py:-1256
> -            return "-php7.1"

I missed that there was already support for 7.1. OK then!

Comment 5 Philippe Normand 2018-06-11 07:28:23 PDT

Committed r232711: <https://trac.webkit.org/changeset/232711>

Comment 6 Radar WebKit Bug Importer 2018-06-11 07:29:21 PDT

<rdar://problem/41003560>