Bug 186520

Summary:

Add performance logging for slow cache retrieves

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, cgarcia, commit-queue, ews-watchlist, ggaren, krollin

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	none
patch	none
patch	none

Description Antti Koivisto 2018-06-11 06:28:19 PDT

We sometimes see slow cache retrieves in logs. Add some more logging for these cases.

Comment 1 Antti Koivisto 2018-06-11 06:28:35 PDT

<rdar://problem/41002070>

Comment 2 Antti Koivisto 2018-06-11 06:43:04 PDT

Created attachment 342423 [details]
patch

Comment 3 Antti Koivisto 2018-06-11 06:53:52 PDT

Created attachment 342424 [details]
patch

Comment 4 EWS Watchlist 2018-06-11 07:00:22 PDT

Attachment 342424 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Antti Koivisto 2018-06-11 07:01:18 PDT

Created attachment 342427 [details]
patch

Comment 6 Antti Koivisto 2018-06-11 07:01:58 PDT

Created attachment 342428 [details]
patch

Comment 7 EWS Watchlist 2018-06-11 07:03:34 PDT

Attachment 342428 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 Geoffrey Garen 2018-06-11 09:30:41 PDT

Comment on attachment 342428 [details]
patch

Shouldn't all these WallTimes be MonotonicTimes?

I don't think we want logs that claim large time values or negative time values when the user crosses daylight savings time or syncs with Apple's time server or something like that.

Comment 9 Antti Koivisto 2018-06-11 09:56:50 PDT

> Shouldn't all these WallTimes be MonotonicTimes?

Yeah, I'll do that.

Comment 10 Antti Koivisto 2018-06-11 12:38:06 PDT

Created attachment 342455 [details]
patch

Comment 11 EWS Watchlist 2018-06-11 12:39:05 PDT

Attachment 342455 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 WebKit Commit Bot 2018-06-12 10:53:08 PDT

Comment on attachment 342455 [details]
patch

Clearing flags on attachment: 342455

Committed r232759: <https://trac.webkit.org/changeset/232759>

Comment 13 WebKit Commit Bot 2018-06-12 10:53:09 PDT

All reviewed patches have been landed.  Closing bug.