Bug 186496

Summary:

[Web Animations] Make WPT test at interfaces/Animation/finish.html pass reliably

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=186509

Attachments:

Description	Flags
Patch	dino: review+

Description Antoine Quint 2018-06-11 04:38:21 PDT

The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/Animation/finish.html is failing reliably, flaky or timing out.

Comment 1 Radar WebKit Bug Importer 2018-06-11 04:38:34 PDT

<rdar://problem/41000179>

Comment 2 Antoine Quint 2018-07-05 08:37:18 PDT

Created attachment 344330 [details]
Patch

Comment 3 Dean Jackson 2018-07-06 11:40:35 PDT

Comment on attachment 344330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344330&action=review

> Source/WebCore/animation/AnimationTimeline.h:84
> +    const ListHashSet<WebAnimation*>& animationsWithoutTarget() const { return m_animationsWithoutTarget; }

You never use this.

Comment 4 Antoine Quint 2018-07-06 11:44:05 PDT

Committed r233585: <https://trac.webkit.org/changeset/233585>

Comment 5 Antoine Quint 2018-07-06 11:44:38 PDT

(In reply to Dean Jackson from comment #3)
> Comment on attachment 344330 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344330&action=review
> 
> > Source/WebCore/animation/AnimationTimeline.h:84
> > +    const ListHashSet<WebAnimation*>& animationsWithoutTarget() const { return m_animationsWithoutTarget; }
> 
> You never use this.

We do in DocumentTimeline.cpp.