Bug 186481

Summary: [GStreamer] flush video sample upon DRAIN query
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eocanha, ews-watchlist, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186599    
Bug Blocks:    
Attachments:
Description Flags
Patch
calvaris: review+
Archive of layout-test-results from ews204 for win-future none

Description Philippe Normand 2018-06-11 03:19:47 PDT
.
Comment 1 Philippe Normand 2018-06-11 03:26:42 PDT
Created attachment 342415 [details]
Patch
Comment 2 Enrique OcaƱa 2018-06-11 04:47:47 PDT
I don't remember if this caused regressions with some layout tests which expected the last frame to be available. Better check it.
Comment 3 Philippe Normand 2018-06-11 06:52:34 PDT
I checked it. No regression detected!
Comment 4 EWS Watchlist 2018-06-11 08:37:19 PDT
Comment on attachment 342415 [details]
Patch

Attachment 342415 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8127912

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 5 EWS Watchlist 2018-06-11 08:37:33 PDT
Created attachment 342435 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Philippe Normand 2018-06-12 02:43:20 PDT
Committed r232747: <https://trac.webkit.org/changeset/232747>
Comment 7 Radar WebKit Bug Importer 2018-06-12 02:45:13 PDT
<rdar://problem/41038703>