Bug 186463

Summary: [Xcode] Clean up and modernize some build setting definitions
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eric.carlson, ews-watchlist, graouts, keith_miller, kondapallykalyan, lforschler, mark.lam, msaboff, saam, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to see if anything breaks
none
Patch to see if anything breaks
none
Patch to see if anything breaksh
none
Clean up and modernize none

mitz
Reported 2018-06-09 12:04:13 PDT
Some build setting definitions are unused or unnecessarily complex.
Attachments
Patch to see if anything breaks (8.91 KB, patch)
2018-06-09 12:04 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch to see if anything breaks (8.98 KB, patch)
2018-06-09 12:11 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch to see if anything breaksh (58.05 KB, patch)
2018-06-09 19:05 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Clean up and modernize (70.05 KB, patch)
2018-06-09 21:11 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2018-06-09 12:04:35 PDT
Created attachment 342368 [details] Patch to see if anything breaks
mitz
Comment 2 2018-06-09 12:11:58 PDT
Created attachment 342369 [details] Patch to see if anything breaks
mitz
Comment 3 2018-06-09 19:05:59 PDT
Created attachment 342377 [details] Patch to see if anything breaksh
EWS Watchlist
Comment 4 2018-06-09 19:51:51 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 5 2018-06-09 21:11:11 PDT
Created attachment 342379 [details] Clean up and modernize
WebKit Commit Bot
Comment 6 2018-06-09 22:18:15 PDT
Comment on attachment 342379 [details] Clean up and modernize Clearing flags on attachment: 342379 Committed r232665: <https://trac.webkit.org/changeset/232665>
WebKit Commit Bot
Comment 7 2018-06-09 22:18:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-09 22:19:17 PDT
<rdar://problem/40976906>
Note You need to log in before you can comment on or make changes to this bug.