| Summary: | [Win] Add IPC error case for broken pipe | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
| Component: | Platform | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, commit-queue, dbates, don.olmstead, ews-watchlist, Hironori.Fujii, pvollan, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=204221 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Basuke Suzuki
2018-06-08 14:00:50 PDT
Created attachment 342323 [details]
PATCH
Comment on attachment 342323 [details] PATCH Attachment 342323 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8091811 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html Created attachment 342351 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 342323 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=342323&action=review > Source/WebKit/ChangeLog:6 > + Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler. Can we add some test? (In reply to Ryosuke Niwa from comment #4) > Comment on attachment 342323 [details] > PATCH > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342323&action=review > > > Source/WebKit/ChangeLog:6 > > + Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler. > > Can we add some test? Ironically this patch is to run TestWebKit correctly. With this patch applied, it runs one step further to the goal so that means it works as expected. I wanna postpone this by opening a new bug for testing this. Does that make sense for you? >Ryosuke Created attachment 342774 [details]
FIX
I'll open a new bug to refactor IPC::Connection for Win soon. Thanks for r+ > Ryosuke
Comment on attachment 342774 [details] FIX Clearing flags on attachment: 342774 Committed r232860: <https://trac.webkit.org/changeset/232860> All reviewed patches have been landed. Closing bug. |