| Summary: | [WebKit on watchOS] Upstream watchOS source additions to OpenSource | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, thorton, timothy, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Wenson Hsieh
2018-06-08 13:37:42 PDT
Created attachment 342317 [details]
Patch
Created attachment 342355 [details]
Patch for landing
Comment on attachment 342317 [details] Patch Attachment 342317 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8094262 New failing tests: http/tests/preload/onload_event.html Created attachment 342357 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 342355 [details] Patch for landing Clearing flags on attachment: 342355 Committed r232659: <https://trac.webkit.org/changeset/232659> Reopening to attach new patch. Created attachment 342570 [details]
Form controls
Comment on attachment 342570 [details] Form controls View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review > Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647 > + if (pickerView == _yearAndEraPicker) > + [_yearAndEraPicker setChangingValue:YES]; > + if (pickerView == _dayPicker) else if? > Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655 > + if (pickerView == _yearAndEraPicker) Ditto > Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145 > +- (void)_handleKeyPress:(WKNumberPadKey)key This is not my favorite thing in the world, but OK. > Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258 > + fadeOutAnimation.fromValue = @(1); Do you need the parens? > Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67 > + [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]]; en_US_POSIX, always? Comment on attachment 342570 [details] Form controls View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review >> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647 >> + if (pickerView == _dayPicker) > > else if? Sounds good. >> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655 >> + if (pickerView == _yearAndEraPicker) > > Ditto Done! >> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145 >> +- (void)_handleKeyPress:(WKNumberPadKey)key > > This is not my favorite thing in the world, but OK. I'm definitely taking suggestions! :/ >> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258 >> + fadeOutAnimation.fromValue = @(1); > > Do you need the parens? Nope! Removed. >> Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67 >> + [_dateFormatter setLocale:[NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]]; > > en_US_POSIX, always? Yes. This is just used to transform hour and minute values into an input value (also see: -[WKDateTimePicker dateFormatterForPicker] on iOS). Created attachment 342581 [details]
Patch for landing
Comment on attachment 342581 [details] Patch for landing Clearing flags on attachment: 342581 Committed r232770: <https://trac.webkit.org/changeset/232770> Created attachment 342908 [details]
Rename more references to extra zoom
Comment on attachment 342908 [details] Rename more references to extra zoom Clearing flags on attachment: 342908 Committed r232916: <https://trac.webkit.org/changeset/232916> |