Bug 186440

Summary: http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186542    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2018-06-08 13:01:04 PDT 
http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled:
--- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-expected.txt
+++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/http/tests/navigation/https-no-store-subframe-in-page-cache-actual.txt
@@ -1,3 +1,3 @@
 ALERT: This page is https and has has a subframe with the no-store cache-control directive. It should go in to the page cache.
-ALERT: PASS: The page was restored from the page cache. Good job!
+ALERT: FAIL: The page was reloaded on back. It should NOT have been.

Looks like we fail to restore the page from PageCache.
Comment 1 Chris Dumez 2018-06-08 13:07:56 PDT 
Created attachment 342311 [details]
Patch
Comment 2 Geoffrey Garen 2018-06-08 13:14:17 PDT 
Comment on attachment 342311 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-06-08 13:59:49 PDT 
Comment on attachment 342311 [details]
Patch

Clearing flags on attachment: 342311

Committed r232638: <https://trac.webkit.org/changeset/232638>
Comment 4 WebKit Commit Bot 2018-06-08 13:59:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-06-08 14:00:41 PDT 
<rdar://problem/40949724>