Bug 186425

Summary:	REGRESSION (r232376): Layout Test inspector/console/webcore-logging.html is a flaky failure
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	Web Inspector	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	inspector-bugzilla-changes, joepeck, keith_miller, realdawei, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=186162

Description Ryan Haddad 2018-06-07 21:38:48 PDT

The following layout test is flaky on macOS Debug WK2

inspector/console/webcore-logging.html

Probable cause:

Unknown, this test started being flaky around https://trac.webkit.org/changeset/232376/webkit

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fconsole%2Fwebcore-logging.html

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/inspector/console/webcore-logging-actual.txt
@@ -33,6 +33,7 @@
 -- Running test case: Console.Logging.LogAsJSONWithoutRepeat
 PASS: Media logging disabled.
 PASS: Verbose media logging has been enabled.
+ERROR: TypeError: undefined is not an object (evaluating 'listener.call')
 PASS: Message logged as JSON.
 PASS: ConsoleMessage repeatCount is 1.
 PASS: Message logged as JSON.

Comment 1 Ryan Haddad 2018-06-07 21:39:26 PDT

We need to find the regression point for this one.

Comment 2 Ryan Haddad 2018-06-08 10:03:11 PDT

David determined that this regressed with https://trac.webkit.org/changeset/232376

Comment 3 Radar WebKit Bug Importer 2018-06-08 11:00:32 PDT

<rdar://problem/40943111>

Comment 4 Dawei Fenton (:realdawei) 2018-06-08 11:49:14 PDT

I've been able to reproduce the failure on a local build of r232376 using the following command:

run-webkit-tests inspector/console/webcore-logging.html --debug --iter 50 -f -g --no-retry

The test passes reliably on the previous build (r232375)

Comment 5 Ryan Haddad 2018-06-12 14:46:22 PDT

Marked test as flaky in https://trac.webkit.org/r232777

Comment 6 Ryan Haddad 2018-11-16 13:43:36 PST

It doesn't look like this has happened recently on the bots and I can not reproduce with Dawei's steps above.

Comment 7 Ryan Haddad 2018-11-16 13:46:59 PST

Removed flaky expectation in https://trac.webkit.org/r238299

Comment 8 Joseph Pecoraro 2018-11-16 16:24:36 PST

Yay!