| Summary: | bmalloc: Fix 'noreturn' warnings when compiling with -std=gnu++17 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Component: | bmalloc | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, jfbastien, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 342184 [details]
Patch v1
Comment on attachment 342184 [details]
Patch v1
Oh dear. Older compilers don't realize this method doesn't return!
Created attachment 342185 [details]
Patch v2
Comment on attachment 342185 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=342185&action=review > Source/bmalloc/bmalloc/BCompiler.h:51 > +#if defined(_MSC_VER) > +#define BCOMPILER_MSVC 1 > +#endif Why do we care about this? We don't compile bmalloc on windows AFAIK. (In reply to Saam Barati from comment #4) > Comment on attachment 342185 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342185&action=review > > > Source/bmalloc/bmalloc/BCompiler.h:51 > > +#if defined(_MSC_VER) > > +#define BCOMPILER_MSVC 1 > > +#endif > > Why do we care about this? We don't compile bmalloc on windows AFAIK. I was porting the WTF_NO_RETURN macro over will full fidelity. If we don't compile bmalloc for Windows, then yes, we can leave this out. Created attachment 342199 [details]
Patch v3
Comment on attachment 342199 [details] Patch v3 Clearing flags on attachment: 342199 Committed r232599: <https://trac.webkit.org/changeset/232599> All reviewed patches have been landed. Closing bug. |
Fix 'noreturn' warnings when compiling bmalloc with -std=gnu++17: Source/bmalloc/bmalloc/Scavenger.cpp:363:1: error: function 'threadRunLoop' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ Source/bmalloc/bmalloc/Scavenger.cpp:358:1: error: function 'threadEntryPoint' could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn] { ^ 2 errors generated.