| Summary: | [Cocoa] Minor ARC tidying of libwebrtc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | WebRTC | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, dbates, eric.carlson, ews-watchlist, mitz, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2018-06-07 09:09:08 PDT
Created attachment 342173 [details]
Patch
Comment on attachment 342173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342173&action=review > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13 > CLANG_ENABLE_OBJC_WEAK = YES; Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding CLANG_ENABLE_OBJC_ARC since it’s redundant? (In reply to Darin Adler from comment #2) > Comment on attachment 342173 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342173&action=review > > > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:13 > > CLANG_ENABLE_OBJC_WEAK = YES; > > Maybe I should also remove CLANG_ENABLE_OBJC_WEAK any time I am adding > CLANG_ENABLE_OBJC_ARC since it’s redundant? If we end up opting individual files out of ARC, either temporarily or permanently, we’d still want them to use Objective-C weak. Anyone willing to review? Everything’s working. Committed r232644: <https://trac.webkit.org/changeset/232644> |