Bug 186395

Summary:

REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, realdawei, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=186130

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2018-06-07 09:00:25 PDT

The following API test is failing after https://trac.webkit.org/changeset/232544/webkit

    TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed
        
        /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:215
        Value of: 100
        Expected: innerWidth
        Which is: 200
        
        
        /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:216
        Value of: 200
        Expected: innerHeight
        Which is: 50

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5419/steps/run-api-tests/logs/stdio

Comment 1 Tim Horton 2018-06-07 09:32:20 PDT

Heh, that makes sense. I should be able to fix by sprinkling some doAfterNextPresentationUpdate in there.

Comment 2 Tim Horton 2018-06-07 09:32:44 PDT

(In the test)

Comment 3 Radar WebKit Bug Importer 2018-06-07 11:09:52 PDT

<rdar://problem/40902427>

Comment 4 Tim Horton 2018-06-07 11:45:36 PDT

Created attachment 342195 [details]
Patch

Comment 5 WebKit Commit Bot 2018-06-07 12:17:45 PDT

Comment on attachment 342195 [details]
Patch

Clearing flags on attachment: 342195

Committed r232593: <https://trac.webkit.org/changeset/232593>

Comment 6 WebKit Commit Bot 2018-06-07 12:17:47 PDT

All reviewed patches have been landed.  Closing bug.