Bug 186387

Summary: [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184770    
Attachments:
Description Flags
Patch
none
Patch none

Description Fujii Hironori 2018-06-07 01:20:33 PDT 
[Win][MiniBrowser] Convert MiniBrowser::updateDeviceScaleFactor to a MainWindow's method

MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
It should be a MainWindow's method.
Comment 1 Fujii Hironori 2018-06-07 01:26:46 PDT 
Created attachment 342139 [details]
Patch
Comment 2 Ryosuke Niwa 2018-06-07 13:15:14 PDT 
Comment on attachment 342139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342139&action=review

> Tools/MiniBrowser/win/MainWindow.cpp:426
> +    m_hURLBarFont = ::CreateFont(scaleFactor * 18, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET,

Where did 18 come from!?
Comment 3 Fujii Hironori 2018-06-07 18:54:23 PDT 
Comment on attachment 342139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342139&action=review

Thank you very much for the review.

>> Tools/MiniBrowser/win/MainWindow.cpp:426
>> +    m_hURLBarFont = ::CreateFont(scaleFactor * 18, 0, 0, 0, FW_NORMAL, FALSE, FALSE, FALSE, DEFAULT_CHARSET,
> 
> Where did 18 come from!?

Good question! urlBarHeight is 24. It should be urlBarHeight * 3.0 / 4.
Comment 4 Fujii Hironori 2018-06-07 19:13:21 PDT 
Created attachment 342230 [details]
Patch
Comment 5 Fujii Hironori 2018-06-07 19:20:00 PDT 
Committed r232609: <https://trac.webkit.org/changeset/232609>
Comment 6 Radar WebKit Bug Importer 2018-06-07 19:20:21 PDT 
<rdar://problem/40920937>