| Summary: | Remove unused debug mode conditions | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, realdawei, ryanhaddad, wilander, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=186603 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brent Fulgham
2018-06-06 11:34:28 PDT
Created attachment 342068 [details]
Patch
Comment on attachment 342068 [details] Patch Attachment 342068 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8035859 New failing tests: http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html Created attachment 342079 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 342068 [details] Patch Attachment 342068 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/8038239 New failing tests: http/tests/preload/onload_event.html Created attachment 342086 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 342098 [details]
Patch
Looks good to me. This change should be very simple and mostly be touching test expectations, which it is. Comment on attachment 342098 [details]
Patch
rs=me
Committed r232585: <https://trac.webkit.org/changeset/232585> Comment on attachment 342098 [details]
Patch
Clearing flags after landing fix.
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html is timing out frequently on iOS after this change: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fpartitioned-and-unpartitioned-cookie-with-partitioning-timeout.html |