Bug 186326

Summary:

REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, rniwa, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews114 for mac-sierra	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Jer Noble

Reported 2018-06-05 16:25:41 PDT

REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in

Attachments
Patch (5.52 KB, patch) 2018-06-05 16:30 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.33 MB, application/zip) 2018-06-05 17:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.75 MB, application/zip) 2018-06-05 17:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-sierra (3.00 MB, application/zip) 2018-06-05 18:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.22 MB, application/zip) 2018-06-05 18:17 PDT, EWS Watchlist	no flags	Details
Patch (4.60 KB, patch) 2018-06-05 18:31 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2018-06-05 16:26:07 PDT

<rdar://problem/40778157>

Jer Noble

Comment 2 2018-06-05 16:30:45 PDT

Created attachment 342003 [details] Patch

EWS Watchlist

Comment 3 2018-06-05 17:35:58 PDT Comment hidden (obsolete)

Comment on attachment 342003 [details] Patch Attachment 342003 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/8019956 New failing tests: media/video-buffering-allowed.html

EWS Watchlist

Comment 4 2018-06-05 17:35:59 PDT Comment hidden (obsolete)

Created attachment 342009 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-06-05 17:43:10 PDT Comment hidden (obsolete)

Comment on attachment 342003 [details] Patch Attachment 342003 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/8020041 New failing tests: media/video-buffering-allowed.html

EWS Watchlist

Comment 6 2018-06-05 17:43:11 PDT Comment hidden (obsolete)

Created attachment 342010 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-06-05 18:15:53 PDT Comment hidden (obsolete)

Comment on attachment 342003 [details] Patch Attachment 342003 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8020305 New failing tests: media/video-buffering-allowed.html

EWS Watchlist

Comment 8 2018-06-05 18:15:54 PDT Comment hidden (obsolete)

Created attachment 342013 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-06-05 18:17:22 PDT Comment hidden (obsolete)

Comment on attachment 342003 [details] Patch Attachment 342003 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/8020289 New failing tests: media/video-buffering-allowed.html

EWS Watchlist

Comment 10 2018-06-05 18:17:24 PDT Comment hidden (obsolete)

Created attachment 342014 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Jer Noble

Comment 11 2018-06-05 18:31:07 PDT

Created attachment 342017 [details] Patch

WebKit Commit Bot

Comment 12 2018-06-05 21:25:54 PDT

Comment on attachment 342017 [details] Patch Clearing flags on attachment: 342017 Committed r232534: <https://trac.webkit.org/changeset/232534>

WebKit Commit Bot

Comment 13 2018-06-05 21:25:56 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 14 2018-06-07 15:37:18 PDT

media/video-buffering-allowed.html was flaky since it was added in https://trac.webkit.org/changeset/231817/webkit, but after this change it is failing very frequently on macOS debug bots. --- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-actual.txt @@ -33,6 +33,6 @@ EXPECTED (internals.elementShouldBufferData(video) == 'false') OK * Remove display:none from the video element. RUN(video.style.removeProperty("display")) -EXPECTED (internals.elementShouldBufferData(video) == 'true') OK +FAIL: did not end fast enough END OF TEST https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-buffering-allowed.html

Note You need to log in before you can comment on or make changes to this bug.