Bug 186326

Summary: REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, rniwa, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews114 for mac-sierra
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch none

Description Jer Noble 2018-06-05 16:25:41 PDT
REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in
Comment 1 Jer Noble 2018-06-05 16:26:07 PDT
<rdar://problem/40778157>
Comment 2 Jer Noble 2018-06-05 16:30:45 PDT
Created attachment 342003 [details]
Patch
Comment 3 EWS Watchlist 2018-06-05 17:35:58 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-06-05 17:35:59 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-06-05 17:43:10 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-06-05 17:43:11 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-06-05 18:15:53 PDT Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-06-05 18:15:54 PDT Comment hidden (obsolete)
Comment 9 EWS Watchlist 2018-06-05 18:17:22 PDT Comment hidden (obsolete)
Comment 10 EWS Watchlist 2018-06-05 18:17:24 PDT Comment hidden (obsolete)
Comment 11 Jer Noble 2018-06-05 18:31:07 PDT
Created attachment 342017 [details]
Patch
Comment 12 WebKit Commit Bot 2018-06-05 21:25:54 PDT
Comment on attachment 342017 [details]
Patch

Clearing flags on attachment: 342017

Committed r232534: <https://trac.webkit.org/changeset/232534>
Comment 13 WebKit Commit Bot 2018-06-05 21:25:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Ryan Haddad 2018-06-07 15:37:18 PDT
media/video-buffering-allowed.html was flaky since it was added in https://trac.webkit.org/changeset/231817/webkit, but after this change it is failing very frequently on macOS debug bots.

--- /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/media/video-buffering-allowed-actual.txt
@@ -33,6 +33,6 @@
 EXPECTED (internals.elementShouldBufferData(video) == 'false') OK
 * Remove display:none from the video element.
 RUN(video.style.removeProperty("display"))
-EXPECTED (internals.elementShouldBufferData(video) == 'true') OK
+FAIL: did not end fast enough
 END OF TEST


https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-buffering-allowed.html