| Summary: | [Cocoa] Retire DispatchPtr, and add more move semantics and simpler #ifs to other smart pointers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, dbates, mitz, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2018-06-05 14:36:17 PDT
Created attachment 341996 [details]
Patch
Comment on attachment 341996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review > Source/WTF/wtf/RetainPtr.h:118 > -#if defined (__OBJC__) && __has_feature(objc_arc) > +#if __has_feature(objc_arc) I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows. Comment on attachment 341996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341996&action=review >> Source/WTF/wtf/RetainPtr.h:118 >> +#if __has_feature(objc_arc) > > I think you might have to keep this in RetainPtr, unless __has_feature is defined away on Windows. All right. I will. Or I could use COMPILER_HAS_CLANG_FEATURE. But I will just leave this unmodified. Even though the space after "defined" drives me a little nuts. Committed r232528: <https://trac.webkit.org/changeset/232528> |