| Summary: | [Cocoa] Improve smart pointer support for ARC (OSObjectPtr/DispatchPtr) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | Web Template Framework | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mitz, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2018-06-04 22:39:44 PDT
Created attachment 341954 [details]
Patch
Comment on attachment 341954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341954&action=review > Source/WTF/wtf/DispatchPtr.h:48 > +#if !(defined(__OBJC__) && __has_feature(objc_arc)) This is OK as-is. Negation tends to be harder to reason about. I find that pushing the negation through an expression tends to make it easier to reason about: !defined(__OBJ__) || !__has_feature(objc_arc) > Source/WTF/wtf/DispatchPtr.h:56 > +#if !(defined(__OBJC__) && __has_feature(objc_arc)) Ditto. > Source/WTF/wtf/DispatchPtr.h:64 > +#if !(defined(__OBJC__) && __has_feature(objc_arc)) Ditto. Comment on attachment 341954 [details] Patch Attachment 341954 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7999285 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html Created attachment 341959 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Committed r232509: <https://trac.webkit.org/changeset/232509> |