Bug 186296

Summary: [Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebCore Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186288
Attachments:
Description Flags
Patch
none
Patch none

Description Fujii Hironori 2018-06-04 18:38:28 PDT 
[Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/788

> ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(624): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments
> ..\..\Source\WebCore\platform\win\PopupMenuWin.cpp(625): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionForegroundColor': function does not take 0 arguments
Comment 1 Fujii Hironori 2018-06-04 19:03:22 PDT 
>PopupMenuWin.cpp
>c:\webkit\ga\source\webcore\platform\win\popupmenuwin.cpp(624): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments
>c:\webkit\ga\source\webcore\platform\win\popupmenuwin.cpp(625): error C2660: 'WebCore::RenderTheme::activeListBoxSelectionForegroundColor': function does not take 0 arguments
>RenderThemeWin.cpp
>c:\webkit\ga\source\webcore\rendering\renderthemewin.cpp(316): error C2660: 'WebCore::RenderThemeWin::platformActiveSelectionForegroundColor': function does not take 0 arguments
Comment 2 Timothy Hatcher 2018-06-04 19:18:24 PDT 
Created attachment 341947 [details]
Patch
Comment 3 Timothy Hatcher 2018-06-04 19:29:28 PDT 
Created attachment 341948 [details]
Patch
Comment 4 Fujii Hironori 2018-06-04 20:57:51 PDT 
I've confirmed your patch fixes the break in my PC. Thank you for working on this.
Comment 5 WebKit Commit Bot 2018-06-04 21:12:53 PDT 
Comment on attachment 341948 [details]
Patch

Clearing flags on attachment: 341948

Committed r232500: <https://trac.webkit.org/changeset/232500>
Comment 6 WebKit Commit Bot 2018-06-04 21:12:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-04 21:13:19 PDT 
<rdar://problem/40793328>