| Summary: | run-testmem should have a dry run option and an option to parse the stdout of executing the dry run | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, joepeck, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2018-06-04 17:20:29 PDT
Created attachment 341976 [details]
patch
Comment on attachment 341976 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review > Tools/Scripts/run-testmem:40 > + puts "--parse (-p) After executing the dry run, capture its stdout and write it to a file. Pass the path to that file for this option and run-testmem will compute the results of the benchmark run." > + puts "--help (-h) print this message" Some of these start with a capital and end in a period, some don't. Should be consistent. > Tools/Scripts/run-testmem:261 > + Nit: drop empty line Created attachment 341978 [details]
patch
(In reply to Saam Barati from comment #3) > Created attachment 341978 [details] > patch Addressed Joe's comments. Comment on attachment 341976 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review r=me with fixes. > Tools/Scripts/run-testmem:138 > filePath = dirPath.join(filename).to_s > + filePath = Pathname.new($scriptPath).join(filename).to_s if $scriptPath I think line 137 is unnecessary now. Comment on attachment 341976 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=341976&action=review >> Tools/Scripts/run-testmem:138 >> + filePath = Pathname.new($scriptPath).join(filename).to_s if $scriptPath > > I think line 137 is unnecessary now. Oops, never mind. I missed the "if $scriptPath". Line 137 is necessary. Comment on attachment 341978 [details] patch Clearing flags on attachment: 341978 Committed r232517: <https://trac.webkit.org/changeset/232517> All reviewed patches have been landed. Closing bug. |