| Summary: | AR Badging on transparent thumbnail images makes the glyph look really dark | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2018-06-04 16:07:02 PDT
Created attachment 341936 [details]
Patch
Comment on attachment 341936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1874 > + // Clip out the circle to only show the shadow Please add a period to the end of the sentence. > Source/WebCore/rendering/RenderThemeIOS.mm:1876 > + CGRect imageRect = static_cast<CGRect>(rect); Can this be CGRect imageRect { rect }; ? Comment on attachment 341936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:1876 >> + CGRect imageRect = static_cast<CGRect>(rect); > > Can this be CGRect imageRect { rect }; ? I didn't even need this. I can just autocast from IntRect. Committed r232487: <https://trac.webkit.org/changeset/232487> |