Bug 186288

Summary: Selection color is dark when using Safari in dark mode
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Layout and RenderingAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bfulgham, commit-queue, Hironori.Fujii, megan_gardner, simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186296
Attachments:
Description Flags
Patch
none
Patch none

Description Timothy Hatcher 2018-06-04 15:36:21 PDT 
The selection color should be light, since Safari does not use system appearance for web content.

<rdar://problem/38438625>
Comment 1 Timothy Hatcher 2018-06-04 15:46:37 PDT 
Created attachment 341926 [details]
Patch
Comment 2 Timothy Hatcher 2018-06-04 15:54:51 PDT 
Created attachment 341931 [details]
Patch
Comment 3 Megan Gardner 2018-06-04 16:22:39 PDT 
Comment on attachment 341931 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-04 16:38:31 PDT 
Comment on attachment 341931 [details]
Patch

Clearing flags on attachment: 341931

Committed r232486: <https://trac.webkit.org/changeset/232486>
Comment 5 WebKit Commit Bot 2018-06-04 16:38:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Fujii Hironori 2018-06-04 19:04:04 PDT 
Windows ports can't compile.
Filed Bug 186296