Bug 186287

Summary: Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, japhet, joepeck, kangil.han, kondapallykalyan, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2018-06-04 15:22:01 PDT
Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy".
Attachments
Patch (153.17 KB, patch)
2018-06-04 15:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (153.45 KB, patch)
2018-06-04 16:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (153.42 KB, patch)
2018-06-04 20:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-04 15:22:23 PDT
<rdar://problem/40783352>
Chris Dumez
Comment 2 2018-06-04 15:49:04 PDT
Created attachment 341927 [details] Patch
Chris Dumez
Comment 3 2018-06-04 16:00:54 PDT
Created attachment 341932 [details] Patch
youenn fablet
Comment 4 2018-06-04 18:17:37 PDT
Comment on attachment 341932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341932&action=review > Source/WebCore/ChangeLog:9 > + CrossOriginWindowPolicy Not needed > Source/WebCore/page/AbstractDOMWindow.cpp:41 > AbstractDOMWindow::AbstractDOMWindow(GlobalWindowIdentifier&& identifier) GlobalWindowIdentifier&& does not seem to bring any advantage over const GlobalWindowIdentifier& or is it special in some way? > Source/WebCore/page/AbstractDOMWindow.h:57 > + CrossOriginWindowPolicy crossOriginWindowPolicy() { return m_crossOriginWindowPolicy; } const > Source/WebCore/page/AbstractDOMWindow.h:69 > + CrossOriginWindowPolicy m_crossOriginWindowPolicy; Can we set the default value here instead of the constructor? > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:637 > + [NSNumber numberWithBool:NO], WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey, Should we set it to true by default for WK1 as well? > Source/WebKitLegacy/win/WebPreferences.cpp:252 > + CFDictionaryAddValue(defaults, CFSTR(WebKitCrossOriginWindowPolicySupportEnabledPreferenceKey), kCFBooleanFalse); Is there anything preventing us from aligning windows with other ports? > Tools/DumpRenderTree/mac/DumpRenderTree.mm:865 > + [preferences setCrossOriginWindowPolicySupportEnabled:YES]; If we set it to true in Mac/win, we could remove these lines
Chris Dumez
Comment 5 2018-06-04 20:31:05 PDT
Created attachment 341951 [details] Patch
WebKit Commit Bot
Comment 6 2018-06-04 21:11:57 PDT
Comment on attachment 341951 [details] Patch Clearing flags on attachment: 341951 Committed r232499: <https://trac.webkit.org/changeset/232499>
WebKit Commit Bot
Comment 7 2018-06-04 21:11:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.