| Summary: | Add iOS 12 and watchOS 5 to webkitpy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2018-06-04 14:32:27 PDT
Created attachment 341921 [details]
Patch
This is one huge merge conflict with https://bugs.webkit.org/attachment.cgi?id=341917&action=review (In reply to Alexey Proskuryakov from comment #2) > This is one huge merge conflict with > https://bugs.webkit.org/attachment.cgi?id=341917&action=review Yes. I assumed that https://bugs.webkit.org/attachment.cgi?id=341917&action=review would land first. Comment on attachment 341921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341921&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py:40 > + assert(target_platform in ("mac-yosemite", "mac-elcapitan", "mac-sierra", "mac-highsierra", "win", "ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12")) Do we also need to add empty directories for test results? I believe that run-webkit-tests wants directories to exist. > Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:43 > + (["LayoutTests/platform/ios-simulator-wk1/foo"], ["ios-11", "ios-simulator-11", "ios-12", "ios-simulator-12"]), We don't have any tests that verify what happens when checking in to version specific iOS directories. We should, especially if that works properly. Created attachment 342177 [details]
Patch
attachment 342177 [details] adds tests for versions specific test expectations.
To address Alexey's comment about run-webkit-tests: No, run-webkit-tests does not require that test expectation directories exist.
Comment on attachment 342177 [details] Patch Clearing flags on attachment: 342177 Committed r232877: <https://trac.webkit.org/changeset/232877> All reviewed patches have been landed. Closing bug. |