Bug 186240

Summary: REGRESSION(r232421): Breaks webkitpy tests (Requested by aakashjain on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dbates, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 183744    
Attachments:
Description Flags
ROLLOUT of r232421 none

Description WebKit Commit Bot 2018-06-02 15:44:18 PDT 
https://trac.webkit.org/changeset/232421 broke the build:
Breaks webkitpy tests (Requested by aakashjain on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-06-02 15:44:26 PDT 
Created attachment 341854 [details]
ROLLOUT of r232421

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2018-06-02 16:02:56 PDT 
Comment on attachment 341854 [details]
ROLLOUT of r232421

Clearing flags on attachment: 341854

Committed r232445: <https://trac.webkit.org/changeset/232445>
Comment 3 WebKit Commit Bot 2018-06-02 16:02:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-06-02 16:08:15 PDT 
<rdar://problem/40750942>
Comment 5 Simon Fraser (smfr) 2018-06-27 20:28:26 PDT 
What was the nature of the failures? Would be nice to have a link to follow.
Comment 6 Daniel Bates 2018-06-27 20:58:52 PDT 
(In reply to Simon Fraser (smfr) from comment #5)
> What was the nature of the failures? Would be nice to have a link to follow.

From what I recall, lldbWebKitTester failed to compile on the commit-queue bot and hence prevented it from committing patches.