Bug 186237

Summary: FunctionRareData::m_objectAllocationProfileWatchpoint is racy
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 164904    
Attachments:
Description Flags
the patch saam: review+

Description Filip Pizlo 2018-06-02 10:31:09 PDT 
We initialize it blind and let it go into auto-watch mode once the DFG adds a watchpoint, but that means that we never notice that it fired if it fires between when the DFG decides to watch it and when it actually adds the watchpoint.
Comment 1 Filip Pizlo 2018-06-02 10:34:05 PDT 
Created attachment 341847 [details]
the patch
Comment 2 Filip Pizlo 2018-06-07 14:01:34 PDT 
Landed in https://trac.webkit.org/changeset/232598/webkit
Comment 3 Radar WebKit Bug Importer 2018-06-07 14:02:24 PDT 
<rdar://problem/40909445>