| Summary: | [ESNext][BigInt] Implement support for "<<" and ">>" | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||||||
| Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 190836 | ||||||||||||
| Bug Blocks: | 179001, 192017 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Caio Lima
2018-06-02 06:52:38 PDT
Created attachment 353017 [details]
WIP - Patch
Attachment 353017 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1244: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/runtime/JSBigInt.cpp:1319: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 186232 has been marked as a duplicate of this bug. *** Created attachment 354092 [details]
WIP - Patch
Comment on attachment 354092 [details]
WIP - Patch
Rebased with master
Created attachment 354818 [details]
WIP - Patch
Created attachment 355827 [details]
Patch
Comment on attachment 355827 [details]
Patch
r=me
Comment on attachment 355827 [details]
Patch
Thank you very much for the review!
Comment on attachment 355827 [details] Patch Clearing flags on attachment: 355827 Committed r238790: <https://trac.webkit.org/changeset/238790> All reviewed patches have been landed. Closing bug. |