Bug 186154

Summary: Support Images Module Level 4's double-position gradient color stop syntax
Product: WebKit Reporter: Florin Malita <fmalita>
Component: CSSAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, dino, megan_gardner, sabouhallawa, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Florin Malita
Reported 2018-05-31 12:00:46 PDT
CSS Images Module Level 4 extends the gradient color-stop syntax to support specifying two positions [1]. This is equivalent to repeating the color for each position, and comes in handy when defining solid color gradient spans -- e.g. red 0%, green 50%, green 100% => red 0%, green 50% 100% CSSWG has approved double-position color stop syntax for shipping ([2],[3]), and we are considering shipping in Blink [4]. Mozilla is also looking at implementing [5]. I'm opening this bug to get some signals from the WebKit community regarding this feature. Thanks! [1] https://drafts.csswg.org/css-images-4/#color-stop-syntax [2] https://github.com/w3c/csswg-drafts/issues/2439 [3] https://www.w3.org/2018/03/28-css-minutes.html#item07 [4] https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/8B9FbeTBIK0 [5] https://bugzilla.mozilla.org/show_bug.cgi?id=1352643
Attachments
Patch for landing (19.52 KB, patch)
2018-09-18 14:00 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2018-05-31 12:15:15 PDT
WPT coverage: https://wpt.fyi/results/css/css-images/gradient/color-stops-parsing.html
Megan Gardner
Comment 2 2018-09-18 13:58:08 PDT
*** Bug 189640 has been marked as a duplicate of this bug. ***
Megan Gardner
Comment 3 2018-09-18 13:58:56 PDT
<rdar://problem/44158152>
Megan Gardner
Comment 4 2018-09-18 14:00:51 PDT
Created attachment 350050 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-09-18 14:38:27 PDT
Comment on attachment 350050 [details] Patch for landing Clearing flags on attachment: 350050 Committed r236155: <https://trac.webkit.org/changeset/236155>
WebKit Commit Bot
Comment 6 2018-09-18 14:38:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.