Bug 185929

Summary: [ESNext][BigInt] Implement support for "=<" and ">=" relational operation
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185379    
Bug Blocks: 179001    
Attachments:
Description Flags
WIP - Patch
none
Patch
ysuzuki: review+
Patch for landing none

Caio Lima
Reported 2018-05-23 17:23:11 PDT
...
Attachments
WIP - Patch (37.09 KB, patch)
2018-05-24 20:13 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (36.27 KB, patch)
2018-05-30 19:12 PDT, Caio Lima 		ysuzuki: review+
DetailsFormatted DiffDiff
Patch for landing (35.25 KB, patch)
2018-05-31 18:48 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2018-05-24 20:13:25 PDT
Created attachment 341243 [details] WIP - Patch It Starts
Caio Lima
Comment 2 2018-05-30 19:12:04 PDT
Created attachment 341638 [details] Patch
Yusuke Suzuki
Comment 3 2018-05-31 06:50:38 PDT
Comment on attachment 341638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341638&action=review r=me with nit. > Source/JavaScriptCore/runtime/Operations.h:324 > + bool result = bigIntCompare(callFrame, p1, p2, JSBigInt::ComparisonMode::LessThanOrEqual); > + RETURN_IF_EXCEPTION(scope, false); > + return result; Just do, scope.release(); return bigIntCompare(callFrame, p1, p2, JSBigInt::ComparisonMode::LessThanOrEqual);
Caio Lima
Comment 4 2018-05-31 18:48:11 PDT
Created attachment 341722 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-05-31 20:30:28 PDT
Comment on attachment 341722 [details] Patch for landing Clearing flags on attachment: 341722 Committed r232386: <https://trac.webkit.org/changeset/232386>
WebKit Commit Bot
Comment 6 2018-05-31 20:30:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-31 20:36:45 PDT
<rdar://problem/40709873>
Note You need to log in before you can comment on or make changes to this bug.