Bug 185797

Summary:

[css-masking] Update clip-path box mapping to unified box

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

CSS

Assignee:

Dirk Schulze <krit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

126207

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Dirk Schulze

Reported 2018-05-18 23:52:03 PDT

The box mapping for fill-box, stroke-box, view-box on HTML elements and content-box, padding-box, margin-box, border-box for SVG elements was aligned with transform-box. Furthermore, fill changed to fill-box and stroke changed to stroke-box. https://drafts.fxtf.org/css-masking-1/#typedef-geometry-box Update the -webkit-clip-path property.

Attachments
Patch (27.77 KB, patch) 2018-05-18 23:59 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Patch for landing (27.76 KB, patch) 2018-06-27 11:57 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Patch for landing (27.65 KB, patch) 2018-06-27 22:26 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2018-05-18 23:59:10 PDT

Created attachment 340772 [details] Patch

Dirk Schulze

Comment 2 2018-06-27 11:57:32 PDT

Created attachment 343734 [details] Patch for landing

WebKit Commit Bot

Comment 3 2018-06-27 12:00:24 PDT

Comment on attachment 343734 [details] Patch for landing Rejecting attachment 343734 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343734, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=343734&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=185797&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 343734 from bug 185797. Fetching: https://bugs.webkit.org/attachment.cgi?id=343734 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 24 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/CSSPrimitiveValueMappings.h Hunk #1 FAILED at 4917. Hunk #2 FAILED at 4945. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSPrimitiveValueMappings.h.rej patching file Source/WebCore/css/CSSValueKeywords.in Hunk #1 succeeded at 886 (offset 13 lines). patching file Source/WebCore/css/StyleBuilderConverter.h Hunk #1 succeeded at 545 with fuzz 2. patching file Source/WebCore/css/parser/CSSPropertyParser.cpp patching file Source/WebCore/rendering/RenderBlock.cpp patching file Source/WebCore/rendering/RenderLayer.cpp Hunk #1 FAILED at 4095. Hunk #2 FAILED at 4106. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderLayer.cpp.rej patching file Source/WebCore/rendering/shapes/BoxShape.cpp Hunk #1 FAILED at 83. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/shapes/BoxShape.cpp.rej patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp Hunk #1 FAILED at 104. Hunk #2 FAILED at 228. Hunk #3 FAILED at 276. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej patching file Source/WebCore/rendering/style/RenderStyleConstants.h Hunk #1 FAILED at 692. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/RenderStyleConstants.h.rej patching file Source/WebCore/rendering/svg/SVGRenderingContext.cpp Hunk #1 FAILED at 137. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/svg/SVGRenderingContext.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt patching file LayoutTests/fast/masking/parsing-clip-path-shape.html patching file LayoutTests/svg/clip-path/clip-path-shape-border-box-expected.svg patching file LayoutTests/svg/clip-path/clip-path-shape-border-box.svg patching file LayoutTests/svg/clip-path/clip-path-shape-content-box-expected.svg patching file LayoutTests/svg/clip-path/clip-path-shape-content-box.svg patching file LayoutTests/svg/clip-path/clip-path-shape-fill.svg patching file LayoutTests/svg/clip-path/clip-path-shape-margin-box-expected.svg patching file LayoutTests/svg/clip-path/clip-path-shape-margin-box.svg patching file LayoutTests/svg/clip-path/clip-path-shape-padding-box-expected.svg patching file LayoutTests/svg/clip-path/clip-path-shape-padding-box.svg patching file LayoutTests/svg/clip-path/clip-path-shape-stroke.svg Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8360993

Dirk Schulze

Comment 4 2018-06-27 22:26:47 PDT

Created attachment 343795 [details] Patch for landing

WebKit Commit Bot

Comment 5 2018-06-28 00:37:35 PDT

Comment on attachment 343795 [details] Patch for landing Clearing flags on attachment: 343795 Committed r233302: <https://trac.webkit.org/changeset/233302>

WebKit Commit Bot

Comment 6 2018-06-28 00:37:37 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2018-06-28 00:38:22 PDT

<rdar://problem/41566533>

Note You need to log in before you can comment on or make changes to this bug.