Bug 184793

Summary: Make back forward cache work with process swapping
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch
cdumez: review+
Patch for landing none

Brady Eidson
Reported 2018-04-19 13:52:11 PDT
Make back forward cache work with process swapping This introduces reattaching to a previous process.
Attachments
Patch (71.80 KB, patch)
2018-04-19 14:18 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
patch (71.82 KB, patch)
2018-04-19 14:45 PDT, Brady Eidson 		cdumez: review+
DetailsFormatted DiffDiff
Patch for landing (71.83 KB, patch)
2018-04-19 20:31 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-04-19 13:52:31 PDT
<rdar://problem/38676604>
Brady Eidson
Comment 2 2018-04-19 14:18:43 PDT
Created attachment 338356 [details] Patch
EWS Watchlist
Comment 3 2018-04-19 14:20:41 PDT
Attachment 338356 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2018-04-19 14:27:35 PDT
GTK bot isn't building because its VM exhausted - Not due to the patch. Will move forward as if there wasn't GTK build coverage for this one.
Brady Eidson
Comment 5 2018-04-19 14:45:12 PDT
Created attachment 338359 [details] patch
EWS Watchlist
Comment 6 2018-04-19 14:46:28 PDT
Attachment 338359 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 7 2018-04-19 16:57:02 PDT
Comment on attachment 338359 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=338359&action=review r=me > Source/WebKit/UIProcess/WebBackForwardList.h:77 > + Vector<BackForwardListItemState> filteredItems(Function<bool(WebBackForwardListItem&)>&&) const; filteredItems is not very consistent with itemStates above. I would suggest filteredItemStates for consistency.
Brady Eidson
Comment 8 2018-04-19 20:31:56 PDT
Created attachment 338391 [details] Patch for landing
EWS Watchlist
Comment 9 2018-04-19 20:34:13 PDT
Attachment 338391 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2018-04-19 21:55:38 PDT
Comment on attachment 338391 [details] Patch for landing Clearing flags on attachment: 338391 Committed r230834: <https://trac.webkit.org/changeset/230834>
Note You need to log in before you can comment on or make changes to this bug.