Bug 184302

Summary:

Start migration to a version of contentsToRootView() that may take scroll offset into account for delegated scrolling

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

Frames

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ews-watchlist, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=182785

Bug Depends on:

Bug Blocks:

184297

Attachments:

Description	Flags
Patch for EWS	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none
Patch	none
Patch	none
Patch	none

Frédéric Wang (:fredw)

Reported 2018-04-04 07:33:27 PDT

Created attachment 337167 [details] Patch for EWS This is similar to bug 182785 but to prepare for bug 184297.

Attachments
Patch for EWS (24.73 KB, patch) 2018-04-04 07:33 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.11 MB, application/zip) 2018-04-04 10:58 PDT, EWS Watchlist	no flags	Details
Patch (29.48 KB, patch) 2018-04-04 12:05 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (471.38 KB, patch) 2018-04-05 01:48 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (29.78 KB, patch) 2018-07-11 06:40 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (29.70 KB, patch) 2018-09-05 07:14 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

EWS Watchlist

Comment 1 2018-04-04 10:57:55 PDT

Comment on attachment 337167 [details] Patch for EWS Attachment 337167 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7205354 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

EWS Watchlist

Comment 2 2018-04-04 10:58:06 PDT

Created attachment 337192 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Frédéric Wang (:fredw)

Comment 3 2018-04-04 12:05:45 PDT

Created attachment 337200 [details] Patch

Frédéric Wang (:fredw)

Comment 4 2018-04-05 01:48:47 PDT

Created attachment 337258 [details] Patch

Frédéric Wang (:fredw)

Comment 5 2018-04-05 01:51:58 PDT

Comment on attachment 337258 [details] Patch Wrong bug.

Frédéric Wang (:fredw)

Comment 6 2018-07-11 06:40:49 PDT

Created attachment 344763 [details] Patch Rebasing...

Frédéric Wang (:fredw)

Comment 7 2018-09-05 07:14:25 PDT

Created attachment 348916 [details] Patch Rebasing...

Simon Fraser (smfr)

Comment 8 2018-09-05 11:10:19 PDT

I kinda wonder if we should just change it and deal with the fallout. I fear that the "deprecated" version of the function will never go away.

Frédéric Wang (:fredw)

Comment 9 2018-09-05 11:36:11 PDT

(In reply to Simon Fraser (smfr) from comment #8) > I kinda wonder if we should just change it and deal with the fallout. I fear > that the "deprecated" version of the function will never go away. I guess this comment applies to bug 182785 too?

Note You need to log in before you can comment on or make changes to this bug.