Bug 181866

Summary:

fetch redirect is incompatible with "no-cors" mode

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dbates, ews-watchlist, japhet, mkwst, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fixing resuming case	none
Fixing resuming case	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Full patch	none
Archive of layout-test-results from webkit-cq-01 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews116 for mac-sierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch for landing	none

youenn fablet

Reported 2018-01-19 11:14:15 PST

fetch redirect is incompatible with "no-cors" mode

Attachments
Patch (25.46 KB, patch) 2018-01-19 11:20 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fixing resuming case (31.34 KB, patch) 2018-01-19 11:46 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fixing resuming case (31.34 KB, patch) 2018-01-19 12:01 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.29 MB, application/zip) 2018-01-19 14:48 PST, EWS Watchlist	no flags	Details
Full patch (29.10 KB, patch) 2018-01-19 15:19 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-sierra (2.37 MB, application/zip) 2018-01-19 16:12 PST, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.80 MB, application/zip) 2018-01-19 16:22 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.46 MB, application/zip) 2018-01-19 16:32 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.18 MB, application/zip) 2018-01-19 16:49 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.25 MB, application/zip) 2018-01-19 16:50 PST, EWS Watchlist	no flags	Details
Patch for landing (32.93 KB, patch) 2018-01-20 00:54 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-01-19 11:15:42 PST

<rdar://problem/35827140>

youenn fablet

Comment 2 2018-01-19 11:20:38 PST

Created attachment 331759 [details] Patch

youenn fablet

Comment 3 2018-01-19 11:46:48 PST

Created attachment 331761 [details] Fixing resuming case

youenn fablet

Comment 4 2018-01-19 12:01:10 PST

Created attachment 331764 [details] Fixing resuming case

EWS Watchlist

Comment 5 2018-01-19 14:48:44 PST

Comment on attachment 331759 [details] Patch Attachment 331759 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6140534 New failing tests: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode-worker.html imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-redirect.https.html imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.html

EWS Watchlist

Comment 6 2018-01-19 14:48:45 PST

Created attachment 331791 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 7 2018-01-19 15:19:23 PST

Created attachment 331794 [details] Full patch

WebKit Commit Bot

Comment 8 2018-01-19 15:57:17 PST

The commit-queue encountered the following flaky tests while processing attachment 331794 [details]: http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: ap@webkit.org, mcatanzaro@igalia.com, oliver@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 9 2018-01-19 15:57:18 PST

The commit-queue encountered the following flaky tests while processing attachment 331794 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 10 2018-01-19 16:12:38 PST

Comment on attachment 331794 [details] Full patch Rejecting attachment 331794 [details] from commit-queue. New failing tests: http/tests/fetch/redirectmode-and-preload.html Full output: http://webkit-queues.webkit.org/results/6142109

WebKit Commit Bot

Comment 11 2018-01-19 16:12:39 PST

Created attachment 331807 [details] Archive of layout-test-results from webkit-cq-01 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 12 2018-01-19 16:22:45 PST

Comment on attachment 331794 [details] Full patch Attachment 331794 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6142230 New failing tests: http/tests/fetch/redirectmode-and-preload.html

EWS Watchlist

Comment 13 2018-01-19 16:22:46 PST

Created attachment 331810 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-01-19 16:32:15 PST

Comment on attachment 331794 [details] Full patch Attachment 331794 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6142379 New failing tests: http/tests/fetch/redirectmode-and-preload.html

EWS Watchlist

Comment 15 2018-01-19 16:32:16 PST

Created attachment 331814 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 16 2018-01-19 16:49:46 PST

Comment on attachment 331794 [details] Full patch Attachment 331794 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6142292 New failing tests: http/tests/fetch/redirectmode-and-preload.html

EWS Watchlist

Comment 17 2018-01-19 16:49:47 PST

Created attachment 331816 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 18 2018-01-19 16:50:14 PST

Comment on attachment 331794 [details] Full patch Attachment 331794 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6142330 New failing tests: http/tests/fetch/redirectmode-and-preload.html

EWS Watchlist

Comment 19 2018-01-19 16:50:16 PST

Created attachment 331817 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 20 2018-01-20 00:54:17 PST

Created attachment 331837 [details] Patch for landing

WebKit Commit Bot

Comment 21 2018-01-20 02:45:29 PST

Comment on attachment 331837 [details] Patch for landing Clearing flags on attachment: 331837 Committed r227270: <https://trac.webkit.org/changeset/227270>

WebKit Commit Bot

Comment 22 2018-01-20 02:45:31 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.