Comment on attachment 328566[details]
WIP Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=328566&action=review> Source/WebCore/platform/graphics/GraphicsLayer.cpp:721
> + if (!m_offsetFromRenderer.isEmpty())
It might be a good idea to make this conditional on a LayerTreeAsTextBehavior flag to avoid having to rebaseline a large number of existing tests.
Created attachment 328567[details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328566[details]
WIP Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=328566&action=review>> Source/WebCore/platform/graphics/GraphicsLayer.cpp:721
>> + if (!m_offsetFromRenderer.isEmpty())
>
> It might be a good idea to make this conditional on a LayerTreeAsTextBehavior flag to avoid having to rebaseline a large number of existing tests.
Maybe I was not sure.
In any case, the condition is wrong, it should isZero() not isEmpty().
Created attachment 328568[details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328571[details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 328572[details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328703[details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328705[details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328707[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 328710[details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328712[details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=328712&action=review>> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
>> (contentsOpaque 1)
>
> It looks like it's more than just debug info.
Well, if you read the C++ change, it should definitely only be debug info. I guess these diffs came from another change unrelated to that patch.
Created attachment 328737[details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328738[details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 328741[details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328746[details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328812[details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 328813[details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 328814[details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Frédéric Wang (:fredw) from comment #23)
> Comment on attachment 328712[details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328712&action=review
>
> >> LayoutTests/compositing/ios/overflow-scroll-touch-tiles-expected.txt:47
> >> (contentsOpaque 1)
> >
> > It looks like it's more than just debug info.
>
> Well, if you read the C++ change, it should definitely only be debug info. I
> guess these diffs came from another change unrelated to that patch.
Frederic added a reason for it in the ChangeLog.
In summary: "the text output is changed. This output is put in a <div>to appear in the dumped tree. However, that makes the corresponding graphics layer taller."
2017-12-06 07:48 PST, Frédéric Wang (:fredw)
2017-12-06 08:19 PST, EWS Watchlist
2017-12-06 08:28 PST, EWS Watchlist
2017-12-06 08:43 PST, EWS Watchlist
2017-12-06 08:44 PST, EWS Watchlist
2017-12-07 09:38 PST, Frédéric Wang (:fredw)
2017-12-07 10:35 PST, EWS Watchlist
2017-12-07 10:46 PST, EWS Watchlist
2017-12-07 11:01 PST, EWS Watchlist
2017-12-07 11:17 PST, EWS Watchlist
2017-12-07 11:32 PST, Frédéric Wang (:fredw)
2017-12-07 12:50 PST, Frédéric Wang (:fredw)
2017-12-07 14:08 PST, EWS Watchlist
2017-12-07 14:13 PST, EWS Watchlist
2017-12-07 14:14 PST, EWS Watchlist
2017-12-07 15:08 PST, EWS Watchlist
2017-12-08 05:56 PST, Frédéric Wang (:fredw)
2017-12-08 06:52 PST, EWS Watchlist
2017-12-08 07:20 PST, EWS Watchlist
2017-12-08 07:29 PST, EWS Watchlist
2017-12-11 08:13 PST, Frédéric Wang (:fredw)
2017-12-14 01:07 PST, Frédéric Wang (:fredw)