Bug 179637

Summary:

[Windows] Fix error while launching subprocess on Windows Python

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

Tools / Tests

Assignee:

Basuke Suzuki <basuke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, basuke, bfulgham, buildbot, commit-queue, don.olmstead, glenn, lforschler, pvollan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

179216

Attachments:

Description	Flags
fix	none
fix test-webkitpy failure	achristensen: review-
fixed	none
fix for test-webkitpy	none
fix conflict	none
fix CRLF	none
remove	none

Basuke Suzuki

Reported 2017-11-13 15:01:03 PST

When python try to launch sub process on Windows, the environment variables passing as unicode causes this error: > TypeError: environment can only contain strings

Attachments
fix (1.50 KB, patch) 2017-11-13 15:27 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
fix test-webkitpy failure (1.54 KB, patch) 2017-11-13 17:56 PST, Basuke Suzuki	achristensen: review-	Details Formatted Diff Diff
fixed (3.79 KB, patch) 2017-11-14 16:10 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
fix for test-webkitpy (9.09 KB, patch) 2017-11-14 16:26 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
fix conflict (9.07 KB, patch) 2017-11-14 16:40 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
fix CRLF (4.43 KB, patch) 2017-11-14 16:42 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
remove (4.01 KB, patch) 2017-11-14 16:47 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2017-11-13 15:27:15 PST

Created attachment 326814 [details] fix Convert environment variables from unicode to str. This is required for Python 2 on Windows.

Basuke Suzuki

Comment 2 2017-11-13 17:56:16 PST

Created attachment 326835 [details] fix test-webkitpy failure

Per Arne Vollan

Comment 3 2017-11-13 18:16:46 PST

Comment on attachment 326835 [details] fix test-webkitpy failure View in context: https://bugs.webkit.org/attachment.cgi?id=326835&action=review > Tools/ChangeLog:6 > + [Windows] Fix error while launching subprocess on Windows Python > + https://bugs.webkit.org/show_bug.cgi?id=179637 > + > + Reviewed by NOBODY (OOPS!). Perhaps you could add an explanation of the problem and the fix in the Changelog? > Tools/Scripts/webkitpy/port/server_process.py:69 > + if env is not None and self._port.host.platform.is_win() and not self._port.host.platform.is_cygwin(): Does the expression 'env is not None' have a more compact form? I think we also should consider adding a 'platform.is_native_win()' function.

Alex Christensen

Comment 4 2017-11-14 13:54:27 PST

Comment on attachment 326835 [details] fix test-webkitpy failure I agree, I think this should be better organized.

Basuke Suzuki

Comment 5 2017-11-14 16:10:24 PST

Created attachment 326934 [details] fixed fixed as commented

Basuke Suzuki

Comment 6 2017-11-14 16:26:03 PST

Created attachment 326939 [details] fix for test-webkitpy

Basuke Suzuki

Comment 7 2017-11-14 16:40:07 PST

Created attachment 326943 [details] fix conflict