Bug 179508

Summary: [WinCairo] Cannot find ImageDiff executable
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, buildbot, commit-queue, don.olmstead, glenn, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179216    
Attachments:
Description Flags
patch
pvollan: review+
fix
none
fix reviewer none

Basuke Suzuki
Reported 2017-11-09 15:17:07 PST
Without Cygwin, it cannot find ImageDiff executable.
Attachments
patch (2.11 KB, patch)
2017-11-09 15:30 PST, Basuke Suzuki 		pvollan: review+
DetailsFormatted DiffDiff
fix (2.11 KB, patch)
2017-11-09 16:09 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
fix reviewer (2.11 KB, patch)
2017-11-09 16:11 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-11-09 15:30:17 PST
Created attachment 326495 [details] patch
Per Arne Vollan
Comment 2 2017-11-09 15:56:59 PST
Comment on attachment 326495 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=326495&action=review R=me. > Tools/Scripts/webkitpy/port/win.py:165 > + """Return current platform is Cygwin or not""" Perhaps change this to "Return whether current platform is Cygwin or not".
Basuke Suzuki
Comment 3 2017-11-09 16:09:13 PST
Created attachment 326501 [details] fix
Basuke Suzuki
Comment 4 2017-11-09 16:11:39 PST
Created attachment 326504 [details] fix reviewer
WebKit Commit Bot
Comment 5 2017-11-09 16:48:54 PST
Comment on attachment 326504 [details] fix reviewer Clearing flags on attachment: 326504 Committed r224656: <https://trac.webkit.org/changeset/224656>
WebKit Commit Bot
Comment 6 2017-11-09 16:48:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 09:43:35 PST
<rdar://problem/35562313>
Note You need to log in before you can comment on or make changes to this bug.