Bug 176230

Summary: Make LegacyCustomProtocolManager optional for network process
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, darin, don.olmstead, rniwa, webkit-bug-importer, yoshiaki.jitsukawa, Yousuke.Kimoto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Make LegacyCustomProtocolManager optional for network process
achristensen: review-
Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes none

Stephan Szabo
Reported 2017-09-01 10:28:07 PDT
As part of doing the WinCairo network process files ( https://bugs.webkit.org/show_bug.cgi?id=176069 ), we'd added a stubbed implementation of LegacyCustomProtocolManager to quiet warnings. There ( https://bugs.webkit.org/show_bug.cgi?id=176069#c4 ) it was suggested that we should not implement this for WinCairo, but LegacyCustomProtocolManager should only be included in the ports that are using it.
Attachments
Make LegacyCustomProtocolManager optional for network process (14.21 KB, patch)
2017-11-30 10:29 PST, Stephan Szabo 		achristensen: review-
DetailsFormatted DiffDiff
Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes (57.28 KB, patch)
2017-11-30 15:52 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2017-11-30 10:29:52 PST
Created attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Make LegacyCustomProtocolManager optional for a port as we were asked to not provide it for WinCairo. Move it from the common file into the individual ports that are currently using it and put code behind a feature disabled for WinCairo. Uploading to test on the bots. Thanks to Shukuwa-san for working on this
Stephan Szabo
Comment 2 2017-11-30 12:15:35 PST
Comment on attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Bots appear to be happy at least.
Alex Christensen
Comment 3 2017-11-30 15:13:02 PST
Comment on attachment 327991 [details] Make LegacyCustomProtocolManager optional for network process Woah, this is good, but it needs to be enabled on Cocoa platforms which don't use CMake.
Stephan Szabo
Comment 4 2017-11-30 15:52:34 PST
Created attachment 328045 [details] Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes
WebKit Commit Bot
Comment 5 2017-11-30 18:04:11 PST
Comment on attachment 328045 [details] Make LegacyCustomProtocolManager optional for network process - add FeatureDefines.xcconfig changes Clearing flags on attachment: 328045 Committed r225377: <https://trac.webkit.org/changeset/225377>
WebKit Commit Bot
Comment 6 2017-11-30 18:04:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-30 18:07:15 PST
<rdar://problem/35788301>
Note You need to log in before you can comment on or make changes to this bug.