Bug 174641

Summary: [Curl] Move detail implementation from ResourceHandle to ResourceHandleInternal
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, buildbot, commit-queue, galpeter
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
PATCH none

Basuke Suzuki
Reported 2017-07-18 12:40:16 PDT
When moving stuff from ResourceHandleManager to ResourceHandle on https://bugs.webkit.org/show_bug.cgi?id=173630, still there're many violation remains between ResourceHandle and ResourceHandleInternal classes. Many of implementation detail should be move to ResourceHandleInternal to improve build speed.
Attachments
PATCH (39.35 KB, patch)
2017-07-18 13:04 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2017-07-18 13:04:20 PDT
Created attachment 315824 [details] PATCH Just moved to hide implementation from public.
Alex Christensen
Comment 2 2017-07-18 14:05:16 PDT
Comment on attachment 315824 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=315824&action=review I don't think ResourceHandleInternal should've ever been separated from ResourceHandle. They should've been one class. Keep in mind, the end goal is to have all this networking code work with the NetworkDataTask abstraction. Carlos Garcia did something similar with lib soup in these bugs, which were very heavily based on the asynchronous ResourceHandle work. https://bugs.webkit.org/show_bug.cgi?id=163597 https://bugs.webkit.org/show_bug.cgi?id=163777 https://bugs.webkit.org/show_bug.cgi?id=163939 > Source/WebCore/platform/network/ResourceHandleInternal.h:92 > + , m_handle { loader } Ideally a ResourceHandleInternal wouldn't need to store a pointer to its ResourceHandle, but whatevs.
WebKit Commit Bot
Comment 3 2017-07-18 14:34:04 PDT
Comment on attachment 315824 [details] PATCH Clearing flags on attachment: 315824 Committed r219630: <http://trac.webkit.org/changeset/219630>
WebKit Commit Bot
Comment 4 2017-07-18 14:34:06 PDT
All reviewed patches have been landed. Closing bug.
Basuke Suzuki
Comment 5 2017-07-18 15:05:24 PDT
> I don't think ResourceHandleInternal should've ever been separated from > ResourceHandle. They should've been one class. Again, please think this to improve the speed of further implementation. Build time it currently issue for productivity. > Keep in mind, the end goal is to have all this networking code work with the > NetworkDataTask abstraction. Carlos Garcia did something similar with lib > soup in these bugs, which were very heavily based on the asynchronous > ResourceHandle work. > https://bugs.webkit.org/show_bug.cgi?id=163597 > https://bugs.webkit.org/show_bug.cgi?id=163777 > https://bugs.webkit.org/show_bug.cgi?id=163939 I'll check them. > > Source/WebCore/platform/network/ResourceHandleInternal.h:92 > > + , m_handle { loader } > > Ideally a ResourceHandleInternal wouldn't need to store a pointer to its > ResourceHandle, but whatevs. Thanks for understanding. We remove that pretty soon.
Note You need to log in before you can comment on or make changes to this bug.