Bug 169890
| Summary: | WebAssembly: can mprotect ever fail? | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | JF Bastien <jfbastien> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 159775 | ||
JF Bastien
WasmMemory uses mprotect and tries to handle its failure. I'm not sure it should ever fail according to the manpage for MacOS. Linux seems to allow failure if the kernel runs out of memory for its internal data structures, which seems *really* bad.
In both cases I suspect we should just assert out.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
JF Bastien
Fixed in other patches.