Bug 166920

Summary:

Remove request.formData property until it gets implemented

Product:

WebKit

Reporter:

Anne van Kesteren <annevk>

Component:

DOM

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

161190

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Anne van Kesteren

Reported 2017-01-11 00:56:40 PST

From testing at https://github.com/w3c/web-platform-tests/pull/4517 it appears that formData() is not implemented. If that's the case it would be better to leave it undefined.

Attachments
Patch (7.17 KB, patch) 2017-01-11 15:15 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (7.13 KB, patch) 2017-01-11 17:58 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-01-11 08:50:34 PST

+Youenn. As far as I can see, our FetchRequest interface already implements FetchBody, which has the formData() operation.

Chris Dumez

Comment 2 2017-01-11 08:53:40 PST

Could be due to: if (isFormData()) { // FIXME: Support consuming FormData. in FetchBody::consume().

Anne van Kesteren

Comment 3 2017-01-11 10:02:55 PST

If you can't implement it before shipping, it would be better to drop the method from the IDL entirely. That's what Chrome is doing (Firefox supports it). Otherwise web developers will have to sniff this in two different ways.

Radar WebKit Bug Importer

Comment 4 2017-01-11 10:07:27 PST

<rdar://problem/29971105>

Sam Weinig

Comment 5 2017-01-11 12:28:02 PST

I'll take a look at fixing this unless Youenn is already started on it.

youenn fablet

Comment 6 2017-01-11 12:36:38 PST

(In reply to comment #5) > I'll take a look at fixing this unless Youenn is already started on it. I was about to fix it, but please go ahead!

youenn fablet

Comment 7 2017-01-11 15:10:51 PST

I forgot there was already bug 161190 to cover this one. I'll use this bug entry to land the one-liner patch to remove the property. This is safer doing it that way for all WebKit users.

youenn fablet

Comment 8 2017-01-11 15:15:44 PST

Created attachment 298617 [details] Patch

Chris Dumez

Comment 9 2017-01-11 15:19:26 PST

Comment on attachment 298617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298617&action=review r=me > Source/WebCore/Modules/fetch/FetchBody.idl:40 > + // FIXME: Add support for form data consumption (https://bugs.webkit.org/show_bug.cgi?id=161190) nit: Missing period at the end.

youenn fablet

Comment 10 2017-01-11 17:58:31 PST

Created attachment 298647 [details] Patch for landing

WebKit Commit Bot

Comment 11 2017-01-11 18:45:34 PST

Comment on attachment 298647 [details] Patch for landing Clearing flags on attachment: 298647 Committed r210616: <http://trac.webkit.org/changeset/210616>

WebKit Commit Bot

Comment 12 2017-01-11 18:45:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.