Bug 166701
| Summary: | WebAssembly: Module.customSections test copying | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | JF Bastien <jfbastien> |
| Component: | JavaScriptCore | Assignee: | Sergey Rubanov <chi187> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | chi187, jfbastien, keith_miller, k_tamkun, saam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 165159 | ||
| Bug Blocks: | 161709 | ||
JF Bastien
In bug #165159 I forgot to check that the ArrayBuffer obtained is always a new object, not a view onto the old. This is important because modifying the ArrayBuffer shouldn't modify the original custom section (there would also be lifetime issues).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sergey Rubanov
https://github.com/WebKit/WebKit/pull/69958
Sergey Rubanov
(This is already fixed in the engine (ArrayBuffer::tryCreate copies the payload). Added a regression test that mutates a returned buffer and checks later customSections results are unchanged.)
EWS
Committed 318396@main (4517c96eee86): <https://commits.webkit.org/318396@main>
Reviewed commits have been landed. Closing PR #69958 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/183840276>